Omit port in Host header for default ports

[splattael]

Hi,

while using rack-reverse-proxy we discovered that proxying to "Apache Coyote" won't work
if the Host header includes the port for default ports (like 80 or 443). E.g.:

Host: example.com:80

In this PR the default port will be skipped in Host header.

Most clients don't set this default port too:

• Port 80 is included in the 'Host' request field (instead of defaulted) when it isn't with other popular HTTP clients request/request#515 (comment)
• https://github.com/ruby/ruby/blob/d46336e71731aa64d71d4573b2741b7de43ec340/lib/net/http/generic_request.rb#L18

Comments?

Kind regards,
Peter

[splattael]

Any comments?

This patch runs in production like a charm for weeks :)

[waterlink]

Looks good, will merge in new main repo: https://github.com/waterlink/rack-reverse-proxy

[waterlink]

Done: waterlink/rack-reverse-proxy#3

[splattael]

@waterlink Thank you!

I didn't know that @jaswope's repo is dead you have taken over :)

Maybe the README should be updated accordingly?

[waterlink]

Well, good idea
On Jul 5, 2015 10:52 PM, "Peter Suschlik" notifications@github.com wrote:

@waterlink https://github.com/waterlink Thank you!

I didn't know that @jaswope https://github.com/jaswope's repo is dead
you have taken over :)

Maybe the README should be updated accordingly?

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

[splattael]

Closing this PR as it has been merged into @waterlink's repo: waterlink/rack-reverse-proxy@026fd7e

Thanks, again!