Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add countryCode #126

Merged
merged 1 commit into from Dec 22, 2022
Merged

add countryCode #126

merged 1 commit into from Dec 22, 2022

Conversation

mirobertod
Copy link
Contributor

Description

Add country code

Are you trying to fix an existing issue?

No

Go Version

$ go version
go version go1.19.4 darwin/arm64

Go Tests

$ go test
2022/12/22 16:06:48 Error while requesting https://loremflickr.com/300/200 : request failed
2022/12/22 16:06:48 Error while creating a temp file: temp file creation failed
2022/12/22 16:06:49 Error while requesting https://thispersondoesnotexist.com/image : request failed
2022/12/22 16:06:49 Error while creating a temp file: temp file creation failed
PASS
ok  	github.com/jaswdr/faker	2.145s

@jaswdr
Copy link
Owner

jaswdr commented Dec 22, 2022

LGTM, congrats on your first contribution @mirobertod 🎉.

@jaswdr
Copy link
Owner

jaswdr commented Dec 22, 2022

The error in the DeepSource workflow could be ignored, I'll send another CR fixing that.

@jaswdr jaswdr merged commit 062deca into jaswdr:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaswdr jaswdr jaswdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mirobertod @jaswdr