Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Typeof Equality #2982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change Typeof Equality #2982

wants to merge 1 commit into from

Conversation

0o001
Copy link

@0o001 0o001 commented Aug 2, 2023

* Change typeof equaltiy (==) with strict equality (===)
Copy link
Collaborator

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going through the trouble to contribute.

I'm not necessarily against this change, but a microbenchmark of the type you referenced is meaningless. It does not represent real world situations and provides no justification for a change to the code, even if you get a big difference (which is not even the case in these benchmarks; the difference is less than the uncertainty).

Please try the Offen benchmark with d122213 as the baseline ref and 6c6bcb1 as the comparison ref, and report back here with your results. If we see a significant improvement, we will continue the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants