Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _.cloneDeep #2723

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add _.cloneDeep #2723

wants to merge 1 commit into from

Conversation

wy1009
Copy link
Contributor

@wy1009 wy1009 commented Jan 29, 2018

add _.cloneDeep function

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.827% when pulling 4c974f4 on wy1009:master into 5c237a7 on jashkenas:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.827% when pulling 4c974f4 on wy1009:master into 5c237a7 on jashkenas:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.827% when pulling 4c974f4 on wy1009:master into 5c237a7 on jashkenas:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.827% when pulling 4c974f4 on wy1009:master into 5c237a7 on jashkenas:master.

@jgonggrijp
Copy link
Collaborator

@wy1009 Thanks for taking the effort to submit a pull request and sorry for the long silence!

I just wanted to remark that you did a really good job. Your tests focus on the important things and the code is short and conventional.

I think this should probably be submitted to Underscore-Contrib, but unfortunately that project is not open to pull requests anymore. I'm looking into a way to blow new life into it, however. @jashkenas let's keep this open in the meanwhile.

@jgonggrijp jgonggrijp added enhancement contrib probably belongs in Underscore-contrib labels Aug 1, 2020
@jgonggrijp jgonggrijp self-assigned this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib probably belongs in Underscore-contrib enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants