Add support for isSafeInteger #2529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include [isSafeInteger](http://www.ecma-international.org/ecma-262/6.0/#sec-number.issafeinteger) as referenced in [issue 2455](#2455) proposed by @jdalton.
jgonggrijp
reviewed
May 9, 2020
| @@ -1344,6 +1344,10 @@ | |||
| return obj != null && hasOwnProperty.call(obj, key); | |||
| }; | |||
|
|
|||
| _.isSafeInteger = function(obj) { | |||
| return _.isNumber(obj) && _.isFinite(obj) && toString.call(parseInt(obj, 10)) === '[object Number]' && Math.floor(obj) === obj; | |||
There was a problem hiding this comment.
Is the third condition really necessary here? It seems kind of redundant with the first. Also, maybe the first is a bit too lenient. The standard seems to suggest that object-wrapped numbers are not allowed, so it should probably be typeof obj === 'number'.
|
Postponing decision on this. As I wrote in #2455, I think this rather belongs in an extension library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include isSafeInteger as referenced in issue 2455 by @jdalton.
The conditions are: