optional parameter for predicate on _.unique #2368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for using custom matcher function for comparison defaults to _.isEqual jashkenas#2311
|
I think this would have a better chance of landing without bundling it with |
this is an additional last predicate parameter rather than defining new methods for using equality comparison other than ===
|
Ive updated this to use a predicate parameter #2311 _.uniq = _.unique = function(array, isSorted, iteratee, context, predicate) {
//... |
| if (!_.isBoolean(isSorted)) { | ||
| context = iteratee; | ||
| iteratee = isSorted; | ||
| isSorted = false; | ||
| predicate = _.isNull(predicate) ? context : predicate; |
There was a problem hiding this comment.
predicate == null && _.isFunction(context) ? ...
There was a problem hiding this comment.
yes, that would be better to ensure that context is a function before assigning it to predicate. thanks.
using optimizeCb for binding making sure that context is a function before assigning to predicate in overloading of unique
|
made the suggested changes, thanks @megawac |
dperrymorrow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows for using custom matcher function for comparison
defaults to
_.isEqualfor comparison #2311added a
_.uniqueWithfunction as discussed, also added_.includeWithas a method to detect if an Array or Collection has an item passing a method. This will be useful if we implement the other methods discussed in the thread as well.