Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a rejected promise instead of false on invalid model save #2489

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Return a rejected promise instead of false on invalid model save #2489

wants to merge 6 commits into from

Commits on Jun 6, 2013

  1. fix jashkenas#2345 return a rejected promise instead of false on inva… 

    …lid model save
    @akre54
    akre54 committed Jun 6, 2013
    Configuration menu
    Copy the full SHA
    deff340 View commit details
    Browse the repository at this point in the history

  2. allow Backbone.Deferred to be overwritten on a framework level. Also … 

    …changes the `rejectWith` calls to just `reject` since most promise implementations dont have this method
    @akre54
    akre54 committed Jun 6, 2013
    Configuration menu
    Copy the full SHA
    b201d1a View commit details
    Browse the repository at this point in the history

  3. add backbone.Deferred sync tests

    @akre54
    akre54 committed Jun 6, 2013
    Configuration menu
    Copy the full SHA
    988b4f0 View commit details
    Browse the repository at this point in the history

  4. return a rejected promise when Model#destroy fails

    @akre54
    akre54 committed Jun 6, 2013
    Configuration menu
    Copy the full SHA
    4bde815 View commit details
    Browse the repository at this point in the history

  5. functional consistency, fix global variable, refactor .done .fail to … 

    ….then
    @akre54
    akre54 committed Jun 6, 2013
    Configuration menu
    Copy the full SHA
    9163635 View commit details
    Browse the repository at this point in the history

  6. destroying unpersisted model should resolve promise, not reject

    @akre54
    akre54 committed Jun 6, 2013
    Configuration menu
    Copy the full SHA
    247f560 View commit details
    Browse the repository at this point in the history