This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
win32: also ENABLE_VIRTUAL_TERMINAL_PROCESSING on stderr #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up on jarun#277. As discussed here[1], it's not really necessary when stdout and stderr are the same console, but it doesn't hurt either. Note that we did not test sys.stderr.isatty() in the code. This has been considered, and deemed not a problem, since stdout is handled first (what really matters) and we have a catch-all pass for any possible exception. [1] jarun#277 (comment)
|
Nice number by the way.
|
|
We're not considering the case where stdout goes to file and stderr does not :) But yeah, that's not a general usecase, so we should be good. In general, we should be getting the same handle for STDOUT and STDERR, so we're good. |
|
stdout goes to file => no color by default. stdout goes to file, color enabled by user, user still wants to use interactive prompt for whatever reason (errors are not colored) => user is insane. |
jarun
suggested changes
Apr 11, 2019
| @@ -3247,17 +3247,19 @@ def main(): | |||
| # https://docs.microsoft.com/en-us/windows/console/setconsolemode | |||
| if platform.release() == '10': | |||
| STD_OUTPUT_HANDLE = -11 | |||
| STD_ERROR_HANDLE = -12 | |||
There was a problem hiding this comment.
Can we put this complete block (from line 3245 to 3266) within a separate API?
|
Oops, I think I've already merged it. But anyway, can we do the API separation? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #277.
As discussed here[1], it's not really necessary when stdout and stderr are the
same console, but it doesn't hurt either.
Note that we did not test sys.stderr.isatty() in the code. This has been
considered, and deemed not a problem, since stdout is handled first (what
really matters) and we have a catch-all pass for any possible exception.
[1] #277 (comment)