Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional keyv instance injection #101

Merged
merged 1 commit into from
May 10, 2022
Merged

feat: optional keyv instance injection #101

merged 1 commit into from
May 10, 2022

Conversation

simonecorsi
Copy link
Contributor

@simonecorsi simonecorsi commented Feb 10, 2021

This feature allows external libraries that wraps cacheable-request to have control on the keyv cache instance while still defaulting to current behavior.

ref: sindresorhus/got#1523

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.03%) to 98.974% when pulling 0d4800f on simonecorsi:master into 0656a46 on lukechilds:master.

@simonecorsi
Copy link
Contributor Author

simonecorsi commented Feb 11, 2021

Coverage decreased (-1.03%) to 98.974% when pulling 0d4800f on simonecorsi:master into 0656a46 on lukechilds:master.

That's unfortunate since the class doesn't return the instance itself to do some unit, gonna check it tonight.

@jaredwray
Copy link
Owner

@simonecorsi - going to accept this and validate the changes.

@jaredwray jaredwray merged commit a48d805 into jaredwray:master May 10, 2022
@simonecorsi
Copy link
Contributor Author

Let me know if you want me to open a PR to update the docs 👍

@jaredwray
Copy link
Owner

@simonecorsi that would be great and if you could also get a fix for unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants