Skip to content

Commit

Permalink
Merge pull request #235 from jaredwray/upgrading-xo-to-0.54.1
Browse files Browse the repository at this point in the history
Upgrading xo to 0.54.1
  • Loading branch information
jaredwray committed Apr 25, 2023
2 parents 1e4ae90 + 54d2da7 commit 4906a62
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"ts-jest-resolver": "^2.0.1",
"ts-node": "^10.9.1",
"typescript": "^5.0.2",
"xo": "^0.53.1"
"xo": "^0.54.1"
},
"jest": {
"collectCoverageFrom": [
Expand Down Expand Up @@ -106,12 +106,14 @@
"@typescript-eslint/ban-types": 0,
"@typescript-eslint/restrict-template-expressions": 0,
"@typescript-eslint/no-unsafe-return": 0,
"@typescript-eslint/no-unsafe-argument": 0,
"new-cap": 0,
"unicorn/no-abusive-eslint-disable": 0,
"@typescript-eslint/restrict-plus-operands": 0,
"@typescript-eslint/no-implicit-any-catch": 0,
"@typescript-eslint/consistent-type-imports": 0,
"@typescript-eslint/consistent-type-definitions": 0,
"@typescript-eslint/prefer-nullish-coalescing": 0,
"n/prefer-global/url": 0
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class CacheableRequest {
await Promise.resolve();
const cacheEntry = options_.cache ? await this.cache.get(key) : undefined;

if (typeof cacheEntry === 'undefined' && !options_.forceRefresh) {
if (cacheEntry === undefined && !options_.forceRefresh) {
makeRequest(options_);
return;
}
Expand Down
2 changes: 1 addition & 1 deletion test/cache.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ test('TTL is not passed to cache if strictTtl is false', async () => {
const cache = {
get: store.get.bind(store),
set(key: any, value: any, ttl: number) {
expect(typeof ttl === 'undefined').toBeTruthy();
expect(ttl === undefined).toBeTruthy();
return store.set(key, value);
},
delete: store.delete.bind(store),
Expand Down

0 comments on commit 4906a62

Please sign in to comment.