Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #131 to we use adapter.getItemText() rather than item.toString #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scottyab
Copy link

@scottyab scottyab commented Jun 4, 2021

  • Fix issue Selected Item shows with .toString() #131 to we use adapter.getItemText() rather than item.toString.
  • ⚠️ had to remove the Hint text handling as I observed several bugs related to manipulating the size of the adapter, i.e +1 with hint present. For example the spinner would be missing the first item and then would crashing with index out of bounds error on selection of items at end of the list. (Just see how the example app doesn't show Cupcake). This might be somewhat drastic to remove however I was short on time and it's not a feature we use so I removed to simplify.
  • Update Gradle so project runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant