Fix #904, Required regenerate and save API (req.session.regenerate is not a function since upgrade to 0.6.0) #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YasharF
added a commit
to sahat/hackathon-starter
that referenced
this pull request
Jul 13, 2023
patch-package allows seamless patching of npm modules (dependencies) without having to fork them. You can modify the files in node_modules and use patch-package to capture the changes and reapply them each time the module is installed. passport.js 0.6.0 currently has a bug that breaks the logout function. The maintainer hasn't had bandwidth to fix it, but there is a pull request in github that addresses the issue. The patch here applies the changes from the pull request to 0.6.0. Passport bug: jaredhanson/passport#904 Passport Fix/Pull Request: jaredhanson/passport#947
raulrene
approved these changes
Nov 28, 2023
|
Is there a possibility of this being merged in the near future? @jaredhanson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background RE: #904
Using
passport@v0.6.0,passport-oauth2@v1.6.1with thecookie-session@v2.0.0module to login with Github, the application throws the following error message:Feature
Utilize the Delegate Pattern and default to an empty implementation so that the code does not throw an error.
Checklist
$ make test) executes successfully.$ make lint) executes successfully. (NOTE: Lint errors are with code not touched by this PR)