Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Session Fixation Concerns #900

Merged
merged 28 commits into from May 20, 2022
Merged

Address Session Fixation Concerns #900

merged 28 commits into from May 20, 2022

Commits on May 17, 2022

  1. Regenerate session on login.

    @jaredhanson
    jaredhanson committed May 17, 2022
    Copy the full SHA
    7e9b9cf View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @jaredhanson
    jaredhanson committed May 17, 2022
    Copy the full SHA
    a7513c4 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Regenerate session in logout.

    @jaredhanson
    jaredhanson committed May 18, 2022
    Copy the full SHA
    a77271f View commit details
    Browse the repository at this point in the history

  2. Save session on login before invoking callback.

    @jaredhanson
    jaredhanson committed May 18, 2022
    Copy the full SHA
    9cde808 View commit details
    Browse the repository at this point in the history

  3. Clear user from old session on logout.

    @jaredhanson
    jaredhanson committed May 18, 2022
    Copy the full SHA
    c018dea View commit details
    Browse the repository at this point in the history

  4. Fix tests.

    @jaredhanson
    jaredhanson committed May 18, 2022
    Copy the full SHA
    fa80b20 View commit details
    Browse the repository at this point in the history

  5. Error if session isn't available.

    @jaredhanson
    jaredhanson committed May 18, 2022
    Copy the full SHA
    fa70e2f View commit details
    Browse the repository at this point in the history

  6. Handle logout without session manager.

    @jaredhanson
    jaredhanson committed May 18, 2022
    Copy the full SHA
    88c1f1b View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Add test.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    71c54f6 View commit details
    Browse the repository at this point in the history

  2. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    cc7606c View commit details
    Browse the repository at this point in the history

  3. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    ee0bf81 View commit details
    Browse the repository at this point in the history

  4. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    cfa8259 View commit details
    Browse the repository at this point in the history

  5. Clean up tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    b395106 View commit details
    Browse the repository at this point in the history

  6. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    3001654 View commit details
    Browse the repository at this point in the history

  7. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    80cc4e3 View commit details
    Browse the repository at this point in the history

  8. Better session detection and exceptions.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    294f22c View commit details
    Browse the repository at this point in the history

  9. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    c1991cf View commit details
    Browse the repository at this point in the history

  10. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    8825a9a View commit details
    Browse the repository at this point in the history

  11. Add optional options to login and logout.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    e69834e View commit details
    Browse the repository at this point in the history

  12. Add option to keep session data.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    a349c2b View commit details
    Browse the repository at this point in the history

  13. Add option to keep session data on logout.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    17111d7 View commit details
    Browse the repository at this point in the history

  14. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    bfba8a1 View commit details
    Browse the repository at this point in the history

  15. No need to guard callback existence.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    29a90d6 View commit details
    Browse the repository at this point in the history

  16. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    f8a175f View commit details
    Browse the repository at this point in the history

  17. Add tests.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    987b191 View commit details
    Browse the repository at this point in the history

  18. Silence verbose logging.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    46756e5 View commit details
    Browse the repository at this point in the history

  19. Change keepSessionData to keepSessionData.

    @jaredhanson
    jaredhanson committed May 19, 2022
    Copy the full SHA
    4f6bd5b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Use utils-merge rather than Object.assign for compatibility.

    @jaredhanson
    jaredhanson committed May 20, 2022
    Copy the full SHA
    8dd79fe View commit details
    Browse the repository at this point in the history