Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document failWithError parameter in authenticate() #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hsource
Copy link

@hsource hsource commented Jan 3, 2019

Helps with #458. I don't know where to submit a change that would update http://www.passportjs.org/docs/authenticate/ but I'd be happy to help with that too

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added test cases which verify the correct operation of this feature or patch.
  • I have added documentation pertaining to this feature or patch.
  • The automated test suite ($ make test) executes successfully.
  • The automated code linting ($ make lint) executes successfully.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.87% when pulling 19cc7c2 on hsource:patch-1 into 882d65e on jaredhanson:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.87% when pulling 19cc7c2 on hsource:patch-1 into 882d65e on jaredhanson:master.

@KerimG
Copy link

KerimG commented Mar 19, 2019

What's the status on this?

@hsource
Copy link
Author

hsource commented Mar 19, 2019

This is purely a documentation change so should be submittable.

@rap2hpoutre
Copy link

I guess it could be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants