Return Strategy if already a Strategy object #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredhanson I would appreciate a review on this. Also CI is falling on one test but old node version (0.6, should not be supported anymore) and not related to this change I think. |
|
@JSteunou if you create this PR at https://github.com/passport-next/passport with tests it will get looked into. |
|
@rwky who is behind passport-next? |
|
@JSteunou I am and one of the companies I work for, we use several passport modules so I forked them into an organization so even if we stop using them for whatever reason or I get hit by a bus others can commit/publish etc. |
|
p.s. if you're interested in helping maintain passport-next I'm happy to add you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613