Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression which made libsecret backend unusable in v23.8.0 #587

Merged
merged 2 commits into from Aug 7, 2022
Merged

Fix regression which made libsecret backend unusable in v23.8.0 #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ceae8
Fix regression which made libsecret backend unusable in v23.8.0
mitya57 Aug 7, 2022
4b2d9e5
Update changelog
jaraco Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
@@ -1,3 +1,8 @@
v23.8.1
-------

* #587: Fix regression in ``libsecret``.

v23.8.0
-------

Expand Down
2 changes: 1 addition & 1 deletion keyring/backend.py
View file
Open in desktop
Expand Up @@ -250,7 +250,7 @@ def _query(self, service, username=None, **base):
scheme['username']: username,
scheme['service']: service,
}
if username
if username is not None
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible some users are relying on username = '' as a non-value for username. We can address that separately if needed.

else {
scheme['service']: service,
},
Expand Down