Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add equality operator to EnvironCredential #549

Merged
merged 4 commits into from Nov 28, 2021
Merged

Add equality operator to EnvironCredential #549

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ae9b23
Add equality operator to EnvironCredential
wwuck Nov 25, 2021
486b9a8
Simply compare vars for equality in EnvironCredential.
jaraco Nov 28, 2021
c43d489
Add tests for comparison for equality.
jaraco Nov 28, 2021
b3f9f2c
Update changelog.
jaraco Nov 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions keyring/credentials.py
View file
Open in desktop
Expand Up @@ -39,6 +39,15 @@ def __init__(self, user_env_var, pwd_env_var):
self.user_env_var = user_env_var
self.pwd_env_var = pwd_env_var

def __eq__(self, other: object) -> bool:
if not isinstance(other, EnvironCredential):
return NotImplemented

return (
self.user_env_var == other.user_env_var
and self.pwd_env_var == other.pwd_env_var
)
jaraco marked this conversation as resolved.
Show resolved Hide resolved

def _get_env(self, env_var):
"""Helper to read an environment variable"""
value = os.environ.get(env_var)
Expand Down