Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_credential to return generic Credential #542

Merged
merged 2 commits into from Nov 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
@@ -1,3 +1,8 @@
v23.2.2
-------

* #542: Change get_credential to return generic Credential.

v23.2.1
-------

Expand Down
2 changes: 1 addition & 1 deletion keyring/backend.py
Expand Up @@ -125,7 +125,7 @@ def get_credential(
self,
service: str,
username: Optional[str],
) -> Optional[credentials.SimpleCredential]:
) -> Optional[credentials.Credential]:
"""Gets the username and password for the service.
Returns a Credential instance.

Expand Down