Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use external importlib_metadata package when python < 3.8 #507

Closed
wants to merge 1 commit into from
Closed

Only use external importlib_metadata package when python < 3.8 #507

wants to merge 1 commit into from

Conversation

PureTryOut
Copy link

importlib_metadata has been integrated into the Python standard library
in 3.8 and is thus unnecessary for any newer versions.
Let's only use the external importlib_metadata package when actually
running on a Python version that doesn't include it already

This is mostly useful for distributions where there is no need to
package importlib_metadata anymore, and it's future proofing for when
the external package stops being developed anymore

@mitya57 mitya57 requested a review from jaraco April 13, 2021 12:45
@PureTryOut
Copy link
Author

I... Don't understand why tests are failing. Locally they succeed fine, and I compared the output of the failing matches variable on both Python 3.7.10 and on 3.9.4, both were the same. I'm not sure why Python behaves differently on CI.

importlib_metadata has been integrated into the Python standard library
in 3.8 and is thus unnecessary for any newer versions.
Let's only use the external importlib_metadata package when actually
running on a Python version that doesn't include it already

This is mostly useful for distributions where there is no need to
package importlib_metadata anymore, and it's future proofing for when
the external package stops being developed anymore
@PureTryOut
Copy link
Author

Never mind, closing this after reading pypa/twine#732 (comment)

Too bad

@PureTryOut PureTryOut closed this Apr 13, 2021
@PureTryOut PureTryOut deleted the importlib-metadata-3.8 branch April 13, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant