Add equality operator to EnvironCredential #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equality operator is useful for testing EnvironCredential
Can you say more about where this would be useful? I don't see any unit tests for EnvironCredential. |
jaraco
reviewed
Nov 28, 2021
|
Apologies, I missed the review before you merged this. I've pushed the initial code up to github at https://github.com/wwuck/keyrings.envvars but I can't push to TestPyPI or PyPI until pypi/warehouse#10030 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful for using EnvironCredential in unit tests if it has the equality operator implemented.