Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change get_credential to return generic Credential #542

Merged
merged 2 commits into from Nov 18, 2021
Merged

Change get_credential to return generic Credential #542

merged 2 commits into from Nov 18, 2021

Conversation

wwuck
Copy link
Contributor

@wwuck wwuck commented Nov 10, 2021

A keyring backend may want to return SimpleCredential or EnvironCredential

@wwuck
Change get_credential to return generic Credential
d07dbdd 
A keyring backend may want to return SimpleCredential or
EnvironCredential
jaraco
jaraco approved these changes Nov 17, 2021
View reviewed changes
Copy link
Owner

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Could you also add a new entry to the changelog with an 0.0.1 bump from the last version?

@wwuck
Copy link
Contributor Author

wwuck commented Nov 17, 2021

Done

@jaraco jaraco merged commit 4e4ec97 into jaraco:main Nov 18, 2021
@wwuck wwuck deleted the feature/patch-1 branch November 25, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wwuck @jaraco