When completion is unavailable, exit with non-zero status and emit me…

…ssage to stderr. Closes #671
jaraco · Apr 2, 2024 · a2aa173 · a2aa173
1 parent 04bdbd3
commit a2aa173
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/keyring/completion.py b/keyring/completion.py
@@ -1,4 +1,5 @@
 import argparse
+import sys
 
 try:
     import shtab
@@ -10,8 +11,8 @@
 
 class _MissingCompletionAction(argparse.Action):
     def __call__(self, parser, namespace, values, option_string):
-        print("Install keyring[completion] for completion support.")
-        parser.exit(0)
+        print("Install keyring[completion] for completion support.", file=sys.stderr)
+        parser.exit(1)
 
 
 def add_completion_notice(parser):

diff --git a/newsfragments/671.bugfix.rst b/newsfragments/671.bugfix.rst
@@ -0,0 +1 @@
+When completion is unavailable, exit with non-zero status and emit message to stderr.