bump base images to use Node.js 20 #1048

BethGriggs · 2024-02-29T21:37:16Z

Description

This is an attempt to test if a combination of #1043 and updating the Dockerfiles to use the Node.js 20 images passes CI 🤞🏻

Which issue(s) does this PR fix

Fixes Upgrade to Node 20 #880

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

BethGriggs · 2024-03-11T16:28:58Z

The following failure in plugin-scalprum-backend only occurs in Node.js 20.8.0 and later:

Error: @internal/plugin-scalprum-backend#test: command (/home/runner/work/backstage-showcase/backstage-showcase/plugins/scalprum-backend) /tmp/yarn--1709242792910-0.9133396591787732/yarn run test exited (1)

BethGriggs · 2024-03-11T17:33:43Z

From a quick bisect this commit in Node.js introduced the failure - nodejs/node#49593. Judging by the fact plugin-scalprum-backend uses mock-fs, I believe we're likely hitting a similar issue as tschaub/mock-fs#378.

davidfestal · 2024-03-28T14:02:49Z

@BethGriggs Do you think you could rebase the PR, and I would review it ?

docker/Dockerfile

github-actions · 2024-03-28T17:46:22Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1048!

BethGriggs · 2024-03-28T17:48:22Z

I think this looks good now, there was a typo in one of the image names causing CI to fail before

BethGriggs · 2024-03-28T18:09:25Z

Any guidance on how to debug this workflow?

Tests on OCP/PR Test — This pipeline stage has failed Details

It seems to bring me to an IBM login page that I am not sure if I have/am supposed to have an account for?

davidfestal · 2024-03-30T09:28:35Z

Any guidance on how to debug this workflow?

Tests on OCP/PR Test — This pipeline stage has failed Details

It seems to bring me to an IBM login page that I am not sure if I have am supposed to have an account for?

cc @josephca

github-actions · 2024-04-26T00:28:53Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1048!

Signed-off-by: Beth Griggs <bgriggs@redhat.com>

github-actions · 2024-04-26T14:52:09Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1048!

nickboldt · 2024-04-26T15:49:44Z

other than the failing prow stuff, I'm good with this. But let's maybe do it on Monday instead of Friday afternoon :D

I would want to see a +1 from @josephca about switching to node20 and how that might impact test suites.

nickboldt · 2024-04-29T16:13:48Z

Failing prow tests:

Run multi-stage test e2e-tests - e2e-tests-janus-idp-backstage-showcase container test expand_less	5m11s
{  )
Backstage is up and running!
######## BASE URL ########
https://rhdh-backstage-showcase-ci.rhdh-pr-os-a9805650830b22c3aee243e51d79565d-0000.us-east.containers.appdomain.cloud
Display pods for verification...
NAME                                                     READY   STATUS      RESTARTS   AGE
hello-world-pipeline-run-echo-bye-pod                    0/1     Completed   0          3m42s
hello-world-pipeline-run-echo-hello-world-pod            0/1     Completed   0          3m42s
rhdh-backstage-55d88b54d-2dnql                           1/1     Running     0          3m33s
rhdh-postgresql-0                                        1/1     Running     0          3m33s
test-app-5987847886-8wkfz                                1/1     Running     0          4m11s
test-app-5987847886-lcbvv                                1/1     Running     0          4m11s
test-backstage-customization-provider-1-build            0/1     Completed   0          4m9s
test-backstage-customization-provider-7f694cd945-vf2hv   1/1     Running     0          2m54s
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ playwright install
Done in 6.78s.
yarn run v1.22.19
$ /tmp/backstage-showcase/e2e-tests/node_modules/.bin/playwright install
Done in 0.70s.
Using PR container image: next
_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.
yarn run v1.22.19
error Command "test" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
cp: cannot stat '/tmp/backstage-showcase/e2e-tests/test-results/*': No such file or directory
Cleaning up before exiting
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-26T14:36:32Z"}
error: failed to execute wrapped command: exit status 1
}

and

Run multi-stage test test phase expand_less	6m14s
{  "e2e-tests" pod "e2e-tests-janus-idp-backstage-showcase" failed: could not watch pod: the pod ci-op-q8vvtct8/e2e-tests-janus-idp-backstage-showcase failed after 6m13s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 1, reason Error
---
)
Backstage is up and running!
######## BASE URL ########
https://rhdh-backstage-showcase-ci.rhdh-pr-os-a9805650830b22c3aee243e51d79565d-0000.us-east.containers.appdomain.cloud
Display pods for verification...
NAME                                                     READY   STATUS      RESTARTS   AGE
hello-world-pipeline-run-echo-bye-pod                    0/1     Completed   0          3m42s
hello-world-pipeline-run-echo-hello-world-pod            0/1     Completed   0          3m42s
rhdh-backstage-55d88b54d-2dnql                           1/1     Running     0          3m33s
rhdh-postgresql-0                                        1/1     Running     0          3m33s
test-app-5987847886-8wkfz                                1/1     Running     0          4m11s
test-app-5987847886-lcbvv                                1/1     Running     0          4m11s
test-backstage-customization-provider-1-build            0/1     Completed   0          4m9s
test-backstage-customization-provider-7f694cd945-vf2hv   1/1     Running     0          2m54s
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ playwright install
Done in 6.78s.
yarn run v1.22.19
$ /tmp/backstage-showcase/e2e-tests/node_modules/.bin/playwright install
Done in 0.70s.
Using PR container image: next
_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.
yarn run v1.22.19
error Command "test" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
cp: cannot stat '/tmp/backstage-showcase/e2e-tests/test-results/*': No such file or directory
Cleaning up before exiting
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-26T14:36:32Z"}
error: failed to execute wrapped command: exit status 1
---
Link to step on registry info site: https://steps.ci.openshift.org/reference/janus-idp-backstage-showcase
Link to job on registry info site: https://steps.ci.openshift.org/job?org=janus-idp&repo=backstage-showcase&branch=main&test=e2e-tests}

openshift-ci · 2024-04-29T16:14:44Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kim-tsao for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sonarcloud · 2024-04-29T16:15:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-04-29T16:38:56Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1048!

josephca · 2024-04-29T17:26:21Z

other than the failing prow stuff, I'm good with this. But let's maybe do it on Monday instead of Friday afternoon :D

I would want to see a +1 from @josephca about switching to node20 and how that might impact test suites.

@nickboldt It shouldn't impact the test as the testing container is based on the playwright image with node20.

nickboldt · 2024-04-29T18:02:48Z

showcase next build succeeded 34 mins ago, pushed to https://quay.io/repository/janus-idp/backstage-showcase?tab=tags (search for next tag)

downstream was already running against an older commit, have forced it to update to see what happens... https://gitlab.cee.redhat.com/rhidp/rhdh/-/pipelines/8072244a

nickboldt · 2024-04-29T20:33:09Z

Build is good in https://gitlab.cee.redhat.com/rhidp/rhdh/-/jobs/21723839 => https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=60856898 => registry-proxy.engineering.redhat.com/rh-osbs/rhdh-rhdh-hub-rhel9:1.2-58 🎉

BethGriggs requested a review from a team as a code owner February 29, 2024 21:37

openshift-ci bot added the do-not-merge/work-in-progress label Feb 29, 2024

openshift-ci bot requested review from schultzp2020 and tumido February 29, 2024 21:37

BethGriggs force-pushed the 20 branch from 476a8cb to 2636383 Compare March 19, 2024 07:58

davidfestal mentioned this pull request Mar 28, 2024

Update Yarn, Node and dependencies #1145

Open

5 tasks

openshift-merge-robot added the needs-rebase label Mar 28, 2024

davidfestal self-requested a review March 28, 2024 14:03

BethGriggs force-pushed the 20 branch from 2636383 to cfc8970 Compare March 28, 2024 15:53

openshift-merge-robot removed the needs-rebase label Mar 28, 2024

BethGriggs commented Mar 28, 2024

View reviewed changes

docker/Dockerfile Outdated Show resolved Hide resolved

BethGriggs force-pushed the 20 branch 2 times, most recently from 09fbc9f to 6185ae1 Compare March 28, 2024 17:19

BethGriggs changed the title ~~[WIP] Update to Node.js 20 in Dockerfiles~~ bump base images to use Node.js 20 Mar 28, 2024

openshift-ci bot removed the do-not-merge/work-in-progress label Mar 28, 2024

openshift-merge-robot added the needs-rebase label Apr 18, 2024

BethGriggs force-pushed the 20 branch from 6185ae1 to 9853575 Compare April 26, 2024 00:03

openshift-merge-robot removed the needs-rebase label Apr 26, 2024

chore: bump base images to use Node.js 20

0dd7d1d

Signed-off-by: Beth Griggs <bgriggs@redhat.com>

BethGriggs force-pushed the 20 branch from 9853575 to 0dd7d1d Compare April 26, 2024 14:24

nickboldt requested a review from josephca April 26, 2024 15:49

Merge branch 'main' into 20

e74bdad

nickboldt merged commit 42206d0 into janus-idp:main Apr 29, 2024
7 of 8 checks passed

BethGriggs deleted the 20 branch April 29, 2024 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump base images to use Node.js 20 #1048

bump base images to use Node.js 20 #1048

BethGriggs commented Feb 29, 2024 •

edited

BethGriggs commented Mar 11, 2024

BethGriggs commented Mar 11, 2024

davidfestal commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

BethGriggs commented Mar 28, 2024

BethGriggs commented Mar 28, 2024 •

edited

davidfestal commented Mar 30, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

nickboldt commented Apr 26, 2024

nickboldt commented Apr 29, 2024

openshift-ci bot commented Apr 29, 2024

sonarcloud bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

josephca commented Apr 29, 2024

nickboldt commented Apr 29, 2024

nickboldt commented Apr 29, 2024

bump base images to use Node.js 20 #1048

bump base images to use Node.js 20 #1048

Conversation

BethGriggs commented Feb 29, 2024 • edited

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

BethGriggs commented Mar 11, 2024

BethGriggs commented Mar 11, 2024

davidfestal commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

BethGriggs commented Mar 28, 2024

BethGriggs commented Mar 28, 2024 • edited

davidfestal commented Mar 30, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

nickboldt commented Apr 26, 2024

nickboldt commented Apr 29, 2024

openshift-ci bot commented Apr 29, 2024

sonarcloud bot commented Apr 29, 2024

Quality Gate passed

github-actions bot commented Apr 29, 2024

josephca commented Apr 29, 2024

nickboldt commented Apr 29, 2024

nickboldt commented Apr 29, 2024

BethGriggs commented Feb 29, 2024 •

edited

BethGriggs commented Mar 28, 2024 •

edited