Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start linting all test/ files as part of test script #704

Merged
merged 1 commit into from Aug 1, 2019

Commits on Jul 8, 2019

  1. Start linting all test/ files as part of test script

    In an effort of ensuring consistent code style in test files as with
    the "production" source code, we should run eslint as part of the
    `$ npm test` script as well.
    
    Most of the related fixes was done by `eslint` using the `--fix` argument.
    
    Only special configuration tweaks for tests compared to the other
    source code, is to allow functions declaration without names. The
    rationale for allowing that in tests, is that the important reason we
    have them in the source code (proper stacktraces) aren't as important
    in test files.
    phillipj committed Jul 8, 2019
    Copy the full SHA
    ac04d6a View commit details
    Browse the repository at this point in the history