Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #589, and possibly fix other manifestations of this bug #618

Merged
merged 8 commits into from Aug 25, 2018
Merged

Resolve #589, and possibly fix other manifestations of this bug #618

merged 8 commits into from Aug 25, 2018

Commits on Jan 21, 2018

  1. prevent value from being returned by Context.prototype.lookup if look… 

    …upHit is false
    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    78ed7a0 View commit details
    Browse the repository at this point in the history

  2. add test for renderability of Array.length via dot notation

    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    a51e1c2 View commit details
    Browse the repository at this point in the history

  3. Remove typeof obj === 'object' constraint in prop lookup 

    Allows rendering properties of primitive types that are not objects, such as a string.
    @dasilvacontin @raymond-lam
    dasilvacontin authored and raymond-lam committed Jan 21, 2018
    Copy the full SHA
    6382ec9 View commit details
    Browse the repository at this point in the history

  4. pop lookup needs to use hasOwnProperty for non-objs

    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    8108045 View commit details
    Browse the repository at this point in the history

  5. re-add constraint in prop lookup, but make property lookups for primi… 

    …tives possible through dot notation
    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    d2f3a48 View commit details
    Browse the repository at this point in the history

  6. add test to address #589 specifically

    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    0e607fe View commit details
    Browse the repository at this point in the history

  7. enhance readability of primitiveHasOwnProperty and add comments to ex… 

    …plain why it is used in one case but not the other
    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    fa75abc View commit details
    Browse the repository at this point in the history

  8. wrap code comments explaining , and use a different example

    @raymond-lam
    raymond-lam committed Jan 21, 2018
    Copy the full SHA
    bd12d95 View commit details
    Browse the repository at this point in the history