Indent Partials #613
Closed
Indent Partials #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As referenced in this issue: janl#562 Partials aren't indented as per the spec: https://github.com/mustache/spec/blob/master/specs/partials.yml#L13-L15 This adds indentation tracking for partials and applies them to the first instance of a partial on a line (to not indent inline partials which would violate a different part of the spec).
|
Any update? |
|
Nope, all updates are in the respective Issues / PRs. We lack maintainer force. Any help reviewing issues / PRs is appreciated! :) |
|
Is it possible to receive the indentation string within the called template? I read the indentation of the first line is part of the specs, but It would be a reasonable solution to merely remove the indentation of the first partial's line and delegating this task to the called template; doing this way, the developer could decide to apply (or not) the indentation as needed. |
|
These changes with some additions was merged in #705, therefore closing this PR. Thanks for your contribution 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in this issue: #562
Partials aren't indented as per the spec: https://github.com/mustache/spec/blob/master/specs/partials.yml#L13-L15
This adds indentation tracking for partials and applies them to the first instance of a partial on a line (to not indent inline partials which would violate a different part of the spec).
It's not really a perfect implementation - to really sort this would require reproaching how tokenising is done, so this sort of slots around the current approach to that.