feat: Run setter logic for nested setters even if value didn't change

Run setter logic for nested setters even if value didn't change. See this: vuejs#7828 (comment). BREAKING CHANGE: Run setter logic for nested setters even if value didn't change.
jan-swiecki · Dec 16, 2018 · 2fd6fc1 · 2fd6fc1
1 parent 77d406b
commit 2fd6fc1
Show file tree

Hide file tree

Showing 13 changed files with 35 additions and 13 deletions.
diff --git a/dist/vue.common.js b/dist/vue.common.js
@@ -1030,7 +1030,9 @@ function defineReactive$$1 (
     set: function reactiveSetter (newVal) {
       var value = getter ? getter.call(obj) : val;
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */

diff --git a/dist/vue.esm.js b/dist/vue.esm.js
@@ -1028,7 +1028,9 @@ function defineReactive$$1 (
     set: function reactiveSetter (newVal) {
       var value = getter ? getter.call(obj) : val;
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */

diff --git a/dist/vue.js b/dist/vue.js
@@ -1034,7 +1034,9 @@
       set: function reactiveSetter (newVal) {
         var value = getter ? getter.call(obj) : val;
         /* eslint-disable no-self-compare */
-        if (newVal === value || (newVal !== newVal && value !== value)) {
+        // We allow same values for getters
+        // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+        if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
           return
         }
         /* eslint-enable no-self-compare */

diff --git a/dist/vue.min.js b/dist/vue.min.js
diff --git a/dist/vue.runtime.common.js b/dist/vue.runtime.common.js
@@ -1021,7 +1021,9 @@ function defineReactive$$1 (
     set: function reactiveSetter (newVal) {
       var value = getter ? getter.call(obj) : val;
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */

diff --git a/dist/vue.runtime.esm.js b/dist/vue.runtime.esm.js
@@ -1019,7 +1019,9 @@ function defineReactive$$1 (
     set: function reactiveSetter (newVal) {
       var value = getter ? getter.call(obj) : val;
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */

diff --git a/dist/vue.runtime.js b/dist/vue.runtime.js
@@ -1025,7 +1025,9 @@
       set: function reactiveSetter (newVal) {
         var value = getter ? getter.call(obj) : val;
         /* eslint-disable no-self-compare */
-        if (newVal === value || (newVal !== newVal && value !== value)) {
+        // We allow same values for getters
+        // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+        if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
           return
         }
         /* eslint-enable no-self-compare */

diff --git a/dist/vue.runtime.min.js b/dist/vue.runtime.min.js
diff --git a/packages/vue-server-renderer/basic.js b/packages/vue-server-renderer/basic.js
@@ -1153,7 +1153,9 @@
       set: function reactiveSetter (newVal) {
         var value = getter ? getter.call(obj) : val;
         /* eslint-disable no-self-compare */
-        if (newVal === value || (newVal !== newVal && value !== value)) {
+        // We allow same values for getters
+        // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+        if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
           return
         }
         /* eslint-enable no-self-compare */

diff --git a/packages/vue-server-renderer/build.js b/packages/vue-server-renderer/build.js
@@ -1161,7 +1161,9 @@ function defineReactive$$1 (
     set: function reactiveSetter (newVal) {
       var value = getter ? getter.call(obj) : val;
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */

diff --git a/packages/vue-template-compiler/browser.js b/packages/vue-template-compiler/browser.js
@@ -1260,7 +1260,9 @@
       set: function reactiveSetter (newVal) {
         var value = getter ? getter.call(obj) : val;
         /* eslint-disable no-self-compare */
-        if (newVal === value || (newVal !== newVal && value !== value)) {
+        // We allow same values for getters
+        // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+        if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
           return
         }
         /* eslint-enable no-self-compare */

diff --git a/packages/vue-template-compiler/build.js b/packages/vue-template-compiler/build.js
@@ -1224,7 +1224,9 @@ function defineReactive$$1 (
     set: function reactiveSetter (newVal) {
       var value = getter ? getter.call(obj) : val;
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */

diff --git a/src/core/observer/index.js b/src/core/observer/index.js
@@ -173,7 +173,9 @@ export function defineReactive (
     set: function reactiveSetter (newVal) {
       const value = getter ? getter.call(obj) : val
       /* eslint-disable no-self-compare */
-      if (newVal === value || (newVal !== newVal && value !== value)) {
+      // We allow same values for getters
+      // See this: https://github.com/vuejs/vue/pull/7828#issuecomment-446820288
+      if ((newVal === value && !getter) || (newVal !== newVal && value !== value)) {
         return
       }
       /* eslint-enable no-self-compare */