Fix #89: #[derive(Schema)] for StructVariants
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems they were guarded under an invalid feature name. Also, they are located with the integration tests for postcard, but the schema module is not publicly visible, so they don't compile. I switched it to public (for now).
Not sure if the test was wrong or the serialization is wrong. For now, I'm after jamesmunns#89, so I'll just make the test green to see if my changes break anything.
A satisfying one-char fix :)
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
|
Hey @barafael, overall looks good!
Thanks! |
|
1.: maybe a simple conditional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here comes a 4-commit sandwich.
The actual issue I believe is fixed with this. However, there are 2 open questions regarding the schema tests (see commit message bodies):
public because they are integration tests. A doc comment abovemod schema;explicitly says not to make experimental featurespub😆Seq, but the array member is schematized as a 10-elementTuple.Let me know what you think :) I love using this crate.