chore: upgrade to Axios 0.25 #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.24.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.24.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
axios v0.21.2 [removes the charset from JSON Content-Type headers](axios/axios#2154). This adjusts the tests to compensate for that change.
use 'axios-mock-adapter' over 'moxios' due to library changes that cause incompatibilites with new versions of axios (over 0.21).
jamesmbourne
changed the title
|
@all-contributors add @ballpointcarrot for test |
|
I've put up a pull request to add @ballpointcarrot! 🎉 |
|
Thanks very much for this @ballpointcarrot! I've gone ahead and bumped this up to |
|
🎉 This PR is included in version 2.4.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #436; leaving as draft until that's applied.Changes the mocking library for axios from moxios to axios-mock-adapter, as moxios doesn't seem to behave with newer versions of axios. With that change applied, we can then update axios itself to 0.24.