Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing documentation about previous singleton argument #280

Merged
merged 1 commit into from Sep 10, 2020

Conversation

galonsky
Copy link
Contributor

@galonsky galonsky commented Sep 4, 2020

I think this documentation is wrong. The new behavior is the same as setting singleton=False because that's the flag needed to NOT share data across instances, right?

Looked at the old documentation:

Alternatively, you can create an instance that does not share data with other instances, by passing singleton=False to the constructor.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.027% when pulling 83e852a on galonsky:patch-1 into ed422fc on jamesls:master.

@bmerry
Copy link
Collaborator

bmerry commented Sep 10, 2020

Thanks for catching this!

@bmerry bmerry merged commit aaaad4b into jamesls:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants