Fix local fonts with colors in name #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirius-A
changed the title
Sirius-A
force-pushed
the
fix/local-fonts-do-names
branch
from
d490b9f
to
5f003fd
Compare
Sirius-A
changed the title
|
Looking good! Thanks for the fix |
|
Makes sense, thanks @Sirius-A ! |
jakubpawlowicz
pushed a commit
that referenced
this pull request
Jan 25, 2020
* fix(optimizer): do not convert colors inside local font names
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes #1058.
This:
became
@font-face{src:local("Some Sans #000 Italic");}instead of
@font-face{src:local("Some Sans Black Italic");}Comments / Suggestions welcome 馃槃