Fix local fonts with colors in name (#1077)

* fix(optimizer): do not convert colors inside local font names
clean-css · Sep 17, 2019 · 3b2d0d2 · 3b2d0d2
1 parent dc728a8
commit 3b2d0d2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/optimizer/level-1/optimize.js b/lib/optimizer/level-1/optimize.js
@@ -37,8 +37,13 @@ var IMPORT_PREFIX_PATTERN = /^@import/i;
 var QUOTED_PATTERN = /^('.*'|".*")$/;
 var QUOTED_BUT_SAFE_PATTERN = /^['"][a-zA-Z][a-zA-Z\d\-_]+['"]$/;
 var URL_PREFIX_PATTERN = /^url\(/i;
+var LOCAL_PREFIX_PATTERN = /^local\(/i;
 var VARIABLE_NAME_PATTERN = /^--\S+$/;
 
+function isLocal(value){
+  return LOCAL_PREFIX_PATTERN.test(value);
+}
+
 function isNegative(value) {
   return value && value[1][0] == '-' && parseFloat(value[1]) < 0;
 }
@@ -443,7 +448,7 @@ function optimizeBody(rule, properties, context) {
         value = !options.compatibility.properties.urlQuotes ?
           removeUrlQuotes(value) :
           value;
-      } else if (isQuoted(value)) {
+      } else if (isQuoted(value) || isLocal(value)) {
         value = levelOptions.removeQuotes ?
           removeQuotes(name, value) :
           value;

diff --git a/test/optimizer/level-1/optimize-test.js b/test/optimizer/level-1/optimize-test.js
@@ -540,6 +540,10 @@ vows.describe('level 1 optimizations')
       'with mixed bold weight and variant #2': [
         'a{font:bold normal 17px sans-serif}',
         'a{font:bold normal 17px sans-serif}'
+      ],
+      'with color in local font name': [
+        '@font-face{src:local("Sans Black Italic")}',
+        '@font-face{src:local("Sans Black Italic")}',
       ]
     }, { level: 1 })
   )