Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution for Turkish website #281

Merged
merged 8 commits into from Apr 22, 2021
Merged

Contribution for Turkish website #281

merged 8 commits into from Apr 22, 2021

Conversation

hakdogan
Copy link
Contributor

This pull request was made to contribute to the website prepared for JakartaOne Livestream Turkish. Details: #279

@netlify
Copy link

netlify bot commented Apr 16, 2021

Deploy preview for jakartaee-jakartaone ready!

Built with commit 10f8bb0

https://deploy-preview-281--jakartaee-jakartaone.netlify.app

i18n/tr.toml Outdated
other = "Yaklaşan Etkinlikler"

[footer-get-social-content]
other = "Canlı etkinlik güncellemeleri, konuşmacı duyuruları, haberler ve daha fazlası için konferansın resmi Twitter hesabı <a href='https://www.twitter.com/@{{ .name }}'>@{{ .name }}</a>'nı takip edin!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are missing the closing quote at the end of this line. That breaks the format which looks like is the current issue with the build. Add that back in and the rest of the file looks good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for determining the problem. I will

Copy link
Contributor

@autumnfound autumnfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved code, just some house keeping regarding ECA validation

@autumnfound
Copy link
Contributor

If you have more changes, feel free to request a review! I'm just leaving an initial +1. This PR has the same issue as EclipseFdn/hugo-solstice-theme#221 in that there are 2 emails associated with the PR (one is good, one is not). If we can verify the other PR, this one will be good too

@autumnfound
Copy link
Contributor

@hakdogan is this ready to go? I can merge it in if it is

@hakdogan
Copy link
Contributor Author

@autumnfound From my point yes, ready

@autumnfound autumnfound merged commit 05f6097 into jakartaee:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants