Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update internal doc refs to get to the proper section at least #1083

Merged
merged 1 commit into from Mar 4, 2021

Conversation

kwsutter
Copy link
Contributor

@kwsutter kwsutter commented Mar 4, 2021

Signed-off-by: Kevin Sutter kwsutter@gmail.com

The markdown rendering in Hugo didn't accomplish what I was looking for. I was trying to create a reference for a specific step in the process, but I've tried several different variations and can't get it to work properly. So, I'm going to revert to just mentioning the desired steps and reference the overall section on creating a final specification. Good enough...

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter
Copy link
Contributor Author

kwsutter commented Mar 4, 2021

@ivargrimstad or @chrisguindon, if you could take a quick review and merge of this PR, I would appreciate it. I'm open to other alternatives, but I haven't been able to get this to work as I had hoped. At a minimum, this PR will at least get the reader back to the "create final spec" section. Thanks!

@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for jakartaee ready!

Built with commit 0a95bf4

https://deploy-preview-1083--jakartaee.netlify.app

@ivargrimstad ivargrimstad merged commit 8591fcb into jakartaee:src Mar 4, 2021
@autumnfound
Copy link
Contributor

I'm in the process of making a PR that addresses this issue in our base theme. Adding an ID to a document should be trivial but it really isn't in most cases, which is one of the gaps in Hugo for sure! It'll be as easy as this in the future:

{{<text_target id="sample_heading">}}Some text here to add an ID to{{</ text_target >}}

@kwsutter
Copy link
Contributor Author

kwsutter commented Mar 4, 2021

I'm in the process of making a PR that addresses this issue in our base theme. Adding an ID to a document should be trivial but it really isn't in most cases, which is one of the gaps in Hugo for sure! It'll be as easy as this in the future:

{{<text_target id="sample_heading">}}Some text here to add an ID to{{</ text_target >}}

That will be excellent! Thanks! Can you link the PR here or send it to my via Slack? I'd like to know when it becomes real.

@kwsutter kwsutter deleted the update-doc-refs branch March 4, 2021 15:37
@autumnfound
Copy link
Contributor

@kwsutter EclipseFdn/hugo-solstice-theme#205 is the PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants