Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc-storage] Use grpc.NewClient #5393

Merged
merged 9 commits into from May 11, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 28, 2024

Which problem is this PR solving?

Description of the changes

  • use grpc.NewClient
  • add extra test

How was this change tested?

  • CI

yurishkuro and others added 8 commits April 26, 2024 19:21
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Use grpc.NewClient [grpc-storage] Use grpc.NewClient Apr 28, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (4dc7708) to head (92eb519).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5393      +/-   ##
==========================================
- Coverage   94.60%   94.59%   -0.02%     
==========================================
  Files         346      346              
  Lines       16953    16951       -2     
==========================================
- Hits        16039    16034       -5     
- Misses        714      716       +2     
- Partials      200      201       +1     
Flag Coverage Δ
badger_v1 10.28% <0.00%> (+<0.01%) ⬆️
badger_v2 6.39% <0.00%> (-0.04%) ⬇️
cassandra-3.x-v1 18.12% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v2 6.14% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 18.12% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2 6.14% <0.00%> (+0.02%) ⬆️
elasticsearch-5.x 5.73% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x 5.74% <0.00%> (+<0.01%) ⬆️
elasticsearch-7.x 5.74% <0.00%> (+<0.01%) ⬆️
elasticsearch-8.x 5.73% <0.00%> (-0.01%) ⬇️
grpc_v1 12.59% <75.00%> (+<0.01%) ⬆️
grpc_v2 11.35% <0.00%> (-0.04%) ⬇️
kafka 9.95% <0.00%> (+<0.01%) ⬆️
opensearch-1.x 5.74% <0.00%> (+<0.01%) ⬆️
opensearch-2.x 5.73% <0.00%> (-0.01%) ⬇️
unittests 91.47% <75.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review May 11, 2024 18:41
@yurishkuro yurishkuro requested a review from a team as a code owner May 11, 2024 18:41
@yurishkuro yurishkuro merged commit 299d942 into jaegertracing:main May 11, 2024
41 checks passed
@yurishkuro yurishkuro deleted the newclient3 branch May 11, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants