Catch panic from Prometheus client on invalid label strings #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportBase: 97.17% // Head: 97.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4051 +/- ##
==========================================
- Coverage 97.17% 97.16% -0.01%
==========================================
Files 295 295
Lines 17393 17413 +20
==========================================
+ Hits 16901 16920 +19
- Misses 396 397 +1
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
…acing#4051) Partially addresses jaegertracing#2944. Supersedes and closes jaegertracing#4050. This only solves the problem in httpmetrics package, we still have other scenarios where malformed strings can leak into Prometheus labels and cause panic, specifically the service-name-based metrics produced by the collector. So I am keeping the original issue open. Hopefully, we can resolve it when we migrate the metrics to OTEL, and allow factories to return errors to be handled gracefully. Signed-off-by: Yuri Shkuro <github@ysh.us>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
…acing#4051) Partially addresses jaegertracing#2944. Supersedes and closes jaegertracing#4050. This only solves the problem in httpmetrics package, we still have other scenarios where malformed strings can leak into Prometheus labels and cause panic, specifically the service-name-based metrics produced by the collector. So I am keeping the original issue open. Hopefully, we can resolve it when we migrate the metrics to OTEL, and allow factories to return errors to be handled gracefully. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2944.
Supersedes and closes #4050.
This only solves the problem in httpmetrics package, we still have other scenarios where malformed strings can leak into Prometheus labels and cause panic, specifically the service-name-based metrics produced by the collector. So I am keeping the original issue open. Hopefully, we can resolve it when we migrate the metrics to OTEL, and allow factories to return errors to be handled gracefully.