Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error from tenancy.InitFromViper #3838

Merged
merged 1 commit into from Aug 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions cmd/collector/app/flags/flags.go
Expand Up @@ -228,11 +228,7 @@ func (opts *GRPCOptions) initFromViper(v *viper.Viper, logger *zap.Logger, cfg s
} else {
return fmt.Errorf("failed to parse gRPC TLS options: %w", err)
}
if tenancy, err := tenancy.InitFromViper(v); err == nil {
opts.Tenancy = tenancy
} else {
return fmt.Errorf("failed to parse Tenancy options: %w", err)
}
opts.Tenancy = tenancy.InitFromViper(v)

return nil
}
Expand Down
6 changes: 1 addition & 5 deletions cmd/query/app/flags.go
Expand Up @@ -125,11 +125,7 @@ func (qOpts *QueryOptions) InitFromViper(v *viper.Viper, logger *zap.Logger) (*Q
} else {
qOpts.AdditionalHeaders = headers
}
if tenancy, err := tenancy.InitFromViper(v); err == nil {
qOpts.Tenancy = tenancy
} else {
return qOpts, fmt.Errorf("failed to parse Tenancy options: %w", err)
}
qOpts.Tenancy = tenancy.InitFromViper(v)
return qOpts, nil
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/tenancy/flags.go
Expand Up @@ -39,7 +39,7 @@ func AddFlags(flags *flag.FlagSet) {
}

// InitFromViper creates tenancy.Options populated with values retrieved from Viper.
func InitFromViper(v *viper.Viper) (Options, error) {
func InitFromViper(v *viper.Viper) Options {
var p Options
p.Enabled = v.GetBool(flagTenancyEnabled)
p.Header = v.GetString(flagTenancyHeader)
Expand All @@ -50,5 +50,5 @@ func InitFromViper(v *viper.Viper) (Options, error) {
p.Tenants = []string{}
}

return p, nil
return p
}
3 changes: 1 addition & 2 deletions pkg/tenancy/flags_test.go
Expand Up @@ -93,8 +93,7 @@ func TestTenancyFlags(t *testing.T) {

err := command.ParseFlags(test.cmd)
require.NoError(t, err)
tenancyCfg, err := InitFromViper(v)
require.NoError(t, err)
tenancyCfg := InitFromViper(v)
assert.Equal(t, test.expected, tenancyCfg)
})
}
Expand Down