Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gRPC storage plugin for better composability #3833

Merged
merged 4 commits into from Aug 1, 2022

Conversation

yurishkuro
Copy link
Member

Allow reusing Remote Storage GRPCHandler without going through plugin APIs

@yurishkuro yurishkuro requested a review from a team as a code owner July 31, 2022 23:08
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #3833 (e3469cc) into main (faf4bc9) will decrease coverage by 0.00%.
The diff coverage is 72.10%.

@@            Coverage Diff             @@
##             main    #3833      +/-   ##
==========================================
- Coverage   97.58%   97.58%   -0.01%     
==========================================
  Files         291      291              
  Lines       16939    16962      +23     
==========================================
+ Hits        16530    16552      +22     
  Misses        323      323              
- Partials       86       87       +1     
Impacted Files Coverage Δ
plugin/storage/grpc/memory/plugin.go 100.00% <ø> (ø)
plugin/storage/grpc/shared/plugin.go 0.00% <0.00%> (ø)
plugin/storage/grpc/shared/grpc_handler.go 74.05% <74.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf4bc9...e3469cc. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 97feed9 into jaegertracing:main Aug 1, 2022
@yurishkuro yurishkuro deleted the memstore branch August 1, 2022 01:16
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant