Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES7 index mapping files for ES8 and higher too #3572

Closed
wants to merge 3 commits into from
Closed

Use ES7 index mapping files for ES8 and higher too #3572

wants to merge 3 commits into from

Conversation

Tornhoof
Copy link

@Tornhoof Tornhoof commented Mar 9, 2022

Signed-off-by: Stefan Seft tornhoof+github@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Modifies the index mapping to use the ES 7 mappings for higher versions too.
  • Modifies the tests to include ES 8
  • Modifies the github ci pipeline to add ES 8.1.0

@Tornhoof Tornhoof requested a review from a team as a code owner March 9, 2022 15:36
@Tornhoof Tornhoof requested a review from yurishkuro March 9, 2022 15:36
Signed-off-by: Stefan Seft <tornhoof+github@gmail.com>
Signed-off-by: Tornhoof <tornhoof@gmail.com>
Signed-off-by: Stefan <tornhoof@gmail.com>
@Tornhoof
Copy link
Author

Tornhoof commented Mar 9, 2022

ah the docker command to run ES 8.1 is changed apparently the old arg --env xpack.monitoring.enabled=false is now called --env xpack.monitoring.templates.enabled=false. Need to fix that.

Signed-off-by: Stefan <tornhoof@gmail.com>
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #3572 (d2e88bf) into main (4ec4cb7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
+ Coverage   96.48%   96.51%   +0.03%     
==========================================
  Files         264      264              
  Lines       15429    15429              
==========================================
+ Hits        14887    14892       +5     
+ Misses        458      454       -4     
+ Partials       84       83       -1     
Impacted Files Coverage Δ
plugin/storage/es/mappings/mapping.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec4cb7...d2e88bf. Read the comment docs.

@Tornhoof
Copy link
Author

Tornhoof commented Mar 9, 2022

Okay I give up, the assumption that changing the mapping for 8 to use the 7.x mapping is apparently not enough or my non-existing go knowledge is not enough to figure out the error. I'm sorry.

@Tornhoof Tornhoof closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch 8.x support
1 participant