Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error from tenancy.InitFromViper #3838

Merged
merged 1 commit into from Aug 1, 2022

Conversation

yurishkuro
Copy link
Member

The function never returns an error, which makes it impossible to test for.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner August 1, 2022 18:00
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #3838 (a809faf) into main (97feed9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3838      +/-   ##
==========================================
+ Coverage   97.58%   97.61%   +0.03%     
==========================================
  Files         291      291              
  Lines       16962    16955       -7     
==========================================
- Hits        16552    16551       -1     
+ Misses        323      319       -4     
+ Partials       87       85       -2     
Impacted Files Coverage Δ
cmd/collector/app/flags/flags.go 100.00% <100.00%> (+3.19%) ⬆️
cmd/query/app/flags.go 100.00% <100.00%> (+4.61%) ⬆️
pkg/tenancy/flags.go 100.00% <100.00%> (ø)
cmd/collector/app/sampling/gprc_handler.go
cmd/collector/app/sampling/grpc_handler.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa2ae7...a809faf. Read the comment docs.

@yurishkuro yurishkuro merged commit ea71bd1 into jaegertracing:main Aug 1, 2022
@yurishkuro yurishkuro deleted the tenancy-viper-no-error branch August 1, 2022 18:50
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant