Skip to content

Commit

Permalink
Fix failed checks
Browse files Browse the repository at this point in the history
Signed-off-by: haanhvu <haanh6594@gmail.com>
  • Loading branch information
haanhvu committed Dec 29, 2023
1 parent 8f50162 commit d780080
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/exporters/storageexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func createTracesExporter(ctx context.Context, set exporter.CreateSettings, conf
exporterhelper.WithCapabilities(consumer.Capabilities{MutatesData: false}),
exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0}),
exporterhelper.WithRetry(exporterhelper.RetrySettings{Enabled: false}),
//Enable queue settings for batch inserts
// Enable queue settings for batch inserts
exporterhelper.WithQueue(exporterhelper.QueueSettings{Enabled: true}),
exporterhelper.WithStart(ex.start),
exporterhelper.WithShutdown(ex.close),
Expand Down
2 changes: 1 addition & 1 deletion plugin/storage/clickhouse/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type Config struct {
Password string `mapstructure:"password"`
Database string `mapstructure:"database"`
SpansTableName string `mapstructure:"spans_table_name"`
//materialized views' names?
// Materialized views' names?
}

const (
Expand Down
4 changes: 4 additions & 0 deletions plugin/storage/clickhouse/spanstore/empty_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// Copyright (c) 2023 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package spanstore

0 comments on commit d780080

Please sign in to comment.