Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some Golang dependencies #1997

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

iblancasa
Copy link
Collaborator

Signed-off-by: Israel Blancas iblancas@redhat.com

Short description of the changes

Upgrade some Golang dependencies:

  • We were referencing k8s.io/client-go with two versions: v12.0.0+incompatible and v0.24.0. Use the newer (v0.24.2)
  • Upgrade github.com/emicklei/go-restful because this issue.
  • Upgrade github.com/openshift/api and github.com/openshift/elasticsearch-operator to being able to upgrade go-restful
  • Other indirect dependencies

Signed-off-by: Israel Blancas <iblancas@redhat.com>
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1997 (d37a2fd) into main (2fa6c29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1997   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         100      100           
  Lines        6387     6387           
=======================================
  Hits         5636     5636           
  Misses        553      553           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa6c29...d37a2fd. Read the comment docs.

@iblancasa iblancasa marked this pull request as ready for review July 13, 2022 15:29
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frzifus frzifus merged commit 6bad747 into jaegertracing:main Jul 13, 2022
@iblancasa iblancasa deleted the upgrade-some-go-deps branch July 13, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants