Log only span context (#153)

* Log only span context * Pin `request` module to compatible version as the latest doesn't work under Node 0.10
jaegertracing · Sep 27, 2017 · 5bdda39 · 5bdda39
1 parent 51e40ec
commit 5bdda39
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
     "lodash": "^4.15.0",
     "minimist": "1.2.0",
     "mocha": "^3.0.1",
-    "request": "^2.74.0",
+    "request": "2.74.0",
     "rsvp": "^3.3.1",
     "semver": "^5",
     "sinon": "^1.17.5",

diff --git a/src/reporters/logging_reporter.js b/src/reporters/logging_reporter.js
@@ -30,7 +30,7 @@ export default class LoggingReporter {
     }
 
     report(span: Span): void {
-        this._logger.info(`Reporting span ${JSON.stringify(span)}`);
+        this._logger.info(`Reporting span ${span.context().toString()}`);
     }
 
     name(): string {

diff --git a/test/all_reporters.js b/test/all_reporters.js
@@ -78,14 +78,22 @@ describe('All Reporters should', () => {
     });
 
     describe('Logging reporter', () => {
-        it('report span logs span as a stringified object', () => {
+        it('logs span as context().toString()', () => {
             let logger = new MockLogger();
             let reporter = new LoggingReporter(logger);
-            let spanMock = { key: 'some-span' };
+            let spanMock = {
+                context: function context() {
+                    return {
+                        toString: function toString() {
+                            return "span-as-string";
+                        }
+                    };
+                }
+            };
 
             reporter.report(spanMock);
 
-            assert.equal(logger._infoMsgs[0], 'Reporting span {"key":"some-span"}');
+            assert.equal(logger._infoMsgs[0], 'Reporting span span-as-string');
         });
     });