Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zipkin] Encode span IDs as full 16-hex strings #601

Merged
merged 1 commit into from Oct 6, 2021
Merged

[zipkin] Encode span IDs as full 16-hex strings #601

merged 1 commit into from Oct 6, 2021

Commits on Oct 6, 2021

  1. Encode SpanID and ParentSpanID as a 16 hex characters in zipkin propa… 

    …gator

Based on the openzipkin/b3-propagation specification, the SpanID and
ParentSpanID are to be encoded as 16 lower-hex characters.

jaegertracing#533 fixed this
for TraceID, and fixed the SpanID.String() method, but did not update
the Zipkin Propagator SpanID encoding.

This fix uses SpanID.String() to ensure proper encoding of the SpanID and
ParentSpandID within the Zipkin Propagator.

Signed-off-by: Nathan Bowler <nzb301@psu.edu>
    @nabowler
    nabowler committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d917c92 View commit details
    Browse the repository at this point in the history