Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceID.String prefix with zeroes #533

Merged
merged 4 commits into from Sep 12, 2020
Merged

TraceID.String prefix with zeroes #533

merged 4 commits into from Sep 12, 2020

Commits on Sep 11, 2020

  1. TraceID.String prefix with zeroes 

    The wire encoding of the TraceID uses zero prefixes (jaegertracing#472).
The JaegerUI also uses zero prefixes (since 1.16).
So it makes sense that the Stringer of the TraceID also does this.

Resolves jaegertracing#532

Signed-off-by: Lukas Vogel <vogel@anapaya.net>
    @lukedirtwalker
    lukedirtwalker committed Sep 11, 2020
    Copy the full SHA
    14e3bff View commit details
    Browse the repository at this point in the history

  2. SpanID.String prefix with zeroes 

    Also test parsing back works.

Signed-off-by: Lukas Vogel <vogel@anapaya.net>
    @lukedirtwalker
    lukedirtwalker committed Sep 11, 2020
    Copy the full SHA
    f8e0c20 View commit details
    Browse the repository at this point in the history

  3. fix tests? 

    how do I run this thing locally?

Signed-off-by: Lukas Vogel <vogel@anapaya.net>
    @lukedirtwalker
    lukedirtwalker committed Sep 11, 2020
    Copy the full SHA
    9b0ab57 View commit details
    Browse the repository at this point in the history

  4. fix tests! 

    Signed-off-by: Lukas Vogel <vogel@anapaya.net>
    @lukedirtwalker
    lukedirtwalker committed Sep 11, 2020
    Copy the full SHA
    b57daf2 View commit details
    Browse the repository at this point in the history