Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite existing AgentHostPort by default value if env not set #474

Closed

Conversation

cuihaikuo
Copy link

Signed-off-by: Cui Haikuo haikuo_cui@shannonai.com

Which problem is this PR solving?

Short description of the changes

  • In ReporterConfig.reporterConfigFromEnv(), if the config struct already has a value and env not set then the default value should not override what's in the struct.

Signed-off-by: Cui Haikuo <haikuo_cui@shannonai.com>
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #474 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage    88.1%   88.13%   +0.02%     
==========================================
  Files          59       59              
  Lines        3507     3515       +8     
==========================================
+ Hits         3090     3098       +8     
  Misses        305      305              
  Partials      112      112
Impacted Files Coverage Δ
config/config_env.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3585cc5...6ebb4f4. Read the comment docs.

@yurishkuro
Copy link
Member

Please use Resolves #123 rather than just linking to a ticket, to allow auto-close on merge.

@yurishkuro
Copy link
Member

Please add a test that demonstrates the issue you're trying to address.

@ilylia
Copy link
Contributor

ilylia commented May 13, 2020

I found this pr, but it looks like the author had forgotten it.
I post a new pr at #513, it resolves the same issue, and with some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants