Skip to content

Commit

Permalink
HTTP Reporter default batch size now inherited (#571)
Browse files Browse the repository at this point in the history
This resolves #570 where HTTP spans were sent in batches of 1
instead of the documented default of 100.

Signed-off-by: R. Aidan Campbell <aidan.campbell@aexp.com>
  • Loading branch information
raidancampbell committed Apr 18, 2021
1 parent 63ddf76 commit fb93505
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/config.go
Expand Up @@ -429,7 +429,7 @@ func (rc *ReporterConfig) NewReporter(
func (rc *ReporterConfig) newTransport(logger jaeger.Logger) (jaeger.Transport, error) {
switch {
case rc.CollectorEndpoint != "":
httpOptions := []transport.HTTPOption{transport.HTTPBatchSize(1), transport.HTTPHeaders(rc.HTTPHeaders)}
httpOptions := []transport.HTTPOption{transport.HTTPHeaders(rc.HTTPHeaders)}
if rc.User != "" && rc.Password != "" {
httpOptions = append(httpOptions, transport.HTTPBasicAuth(rc.User, rc.Password))
}
Expand Down

0 comments on commit fb93505

Please sign in to comment.