Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Yuri Shkuro <github@ysh.us>
  • Loading branch information
yurishkuro committed Nov 27, 2020
1 parent 39e8d47 commit c2234b1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions config/config.go
Expand Up @@ -48,7 +48,7 @@ type Configuration struct {
// Value can be provided by FromEnv() via the environment variable named JAEGER_RPC_METRICS
RPCMetrics bool `yaml:"rpc_metrics"`

// Gen128Bit isntructs the tracer to generate 128-bit wide trace IDs, compatible with W3C Trace Context.
// Gen128Bit instructs the tracer to generate 128-bit wide trace IDs, compatible with W3C Trace Context.
// Value can be provided by FromEnv() via the environment variable named JAEGER_TRACEID_128BIT.
Gen128Bit bool `yaml:"traceid_128bit"`

Expand Down Expand Up @@ -272,8 +272,9 @@ func (c Configuration) NewTracer(options ...Option) (opentracing.Tracer, io.Clos
jaeger.TracerOptions.MaxTagValueLength(opts.maxTagValueLength),
jaeger.TracerOptions.NoDebugFlagOnForcedSampling(opts.noDebugFlagOnForcedSampling),
}

if c.Gen128Bit || opts.gen128Bit {
tracerOptions = append(tracerOptions, jaeger.TracerOptions.Gen128Bit(opts.gen128Bit))
tracerOptions = append(tracerOptions, jaeger.TracerOptions.Gen128Bit(true))
}

for _, tag := range opts.tags {
Expand Down

0 comments on commit c2234b1

Please sign in to comment.