Add filter for bytecode generated by Compose Kotlin compiler plugin #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
filter_kotlin_compose
branch
from
8b0a9fc
to
d994109
Compare
Godin
force-pushed
the
filter_kotlin_compose
branch
from
d994109
to
c1c7d58
Compare
Godin
changed the title
Godin
force-pushed
the
filter_kotlin_compose
branch
from
c1c7d58
to
287986c
Compare
marchof
requested changes
May 4, 2024
org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/KotlinComposeFilterTest.java
Outdated
Show resolved
Hide resolved
org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/KotlinComposeFilterTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc R. Hoffmann <hoffmann@mountainminds.com>
marchof
approved these changes
May 4, 2024
|
Looks like the Azure pipeline had a network failure: |
|
Passed after restart 😉 |
@marchof I assume that silence gives consent - https://github.com/jacoco/example-jacoco-kotlin-compose 😉 |
|
Sorry, I overlooked this comment. Sure, thanks for creating the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no validation test because there is no official way to use Kotlin Compose Compiler Plugin from Maven.
However here is example.zip for which execution of
before this change produces
and with this change installed into local Maven repository produces
Also, I propose to create a repository based on this example with Cl build that will act as a validation test.
Fixes #1208
Closes #1259