Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Kotlin to 1.9.23 #1567

Merged
merged 1 commit into from May 1, 2024
Merged

Upgrade Kotlin to 1.9.23 #1567

merged 1 commit into from May 1, 2024

Conversation

Godin
Copy link
Member

@Godin Godin commented Jan 19, 2024 •
edited

Closes #1336

@Godin Godin added this to the 0.8.12 milestone Jan 19, 2024
@Godin Godin self-assigned this Jan 19, 2024
@Godin Godin added this to Implementation in Current work items via automation Jan 19, 2024
@huangsam
Copy link

huangsam commented Apr 8, 2024 

Results :

Failed tests: 
  KotlinWhenExpressionTest>ValidationTestBase.execute_assertions_in_comments:114->ValidationTestBase.assertFullyCovered:187->ValidationTestBase.assertCoverage:177 Instructions (KotlinWhenExpressionTarget.kt:67) expected:<[FUL]LY_COVERED> but was:<[PART]LY_COVERED>

Tests run: 85, Failures: 1, Errors: 0, Skipped: 0

Looks like this is the culprit for failing builds.

@Godin Godin removed this from the 0.8.12 milestone Apr 9, 2024
@Godin Godin changed the title Upgrade Kotlin to 1.9.22 Upgrade Kotlin to 1.9.23 Apr 30, 2024
@Godin Godin added this to the 0.8.13 milestone Apr 30, 2024
@Godin Godin marked this pull request as ready for review April 30, 2024 21:59
@Godin Godin requested a review from marchof April 30, 2024 21:59
@Godin Godin force-pushed the kotlin_upgrade branch 2 times, most recently from 15d1fe5 to 9fcaee8 Compare April 30, 2024 22:06
@marchof marchof merged commit 1ad4a15 into jacoco:master May 1, 2024
28 checks passed
Current work items automation moved this from Implementation to Done May 1, 2024
@Godin Godin deleted the kotlin_upgrade branch May 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: test language: Kotlin
Projects
Current work items
  
Done
Milestone
0.8.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Godin @huangsam @marchof